Skip to content

Conversation

@vincetran
Copy link
Member

Issue #, if available:
N/A

Description of changes:
Because the fetchingSession.value gets set to false on session retrieval, it has a side effect of showing the "Create Liveness Session" button for a split second before the screen transitions to the LivenessScreen. By only resetting it on exception, we can prevent that flashing from occurring.

How did you test these changes?
Manually, the button no longer flashes and no regression on exception.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners September 24, 2024 00:01
@vincetran vincetran merged commit c1a024d into main Feb 24, 2025
1 check passed
@vincetran vincetran deleted the vinctran/fix-button-flash branch February 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants